harttle / liquidjs / 40743699898

99%

push

github

fix(base64_decode): throw on invalid input in every build (#971)

* fix(base64_decode): render invalid input as an empty string

The two builds disagreed on input that isn't valid Base64. The node
build decodes with Buffer, which skips characters outside the alphabet,
so ordinary text such as "hello" or "[object Object]" decoded to
garbage bytes. The browser builds decode with atob, which throws, so
the same input failed the whole render.

base64_decode now checks the input before decoding, in the filter
shared by both builds: exactly what atob accepts (the standard
alphabet, optional padding and whitespace) decodes as before, and
anything else renders an empty string. Valid input is decoded the same
way by both builds.

Fixes #965

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* docs(base64_decode): say what Shopify renders for invalid input

Shopify/Liquid's default render writes an error message in place of
the filter's output and renders the rest of the page; only render!
raises. "Raises an error" read as failing the render.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(base64_decode): throw on invalid input in every build

Invalid input rendered an empty string. It now throws "invalid base64
provided to base64_decode", the message Shopify/Liquid uses, from the
check both builds share, so the node and browser builds fail the same
way on the same input. Padding stays optional and whitespace ignored,
as both builds accept today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

1206 of 1227 branches covered (98.29%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

3132 of 3138 relevant lines covered (99.81%)

19463.19 hits per line