zhmcclient / python-zhmcclient / test-5002

80%

push

github

Changed StorageGroup.list_candidate_adapter_ports() to return None for FC-type (#2240)

Details:

* FC-type storage groups do not have a property 'candidate-adapter-port-uris'.
  The StorageGroup.list_candidate_adapter_ports() method raised KeyError
  when called for FC-type storage groups. However, this was not documented.

  Changed the method to return None when called for FC-type storage groups
  and documented that.

  This is an incompatible change for users that handle that KeyError exception.
  Such code needs to be changed to test for None instead.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

2245 of 3280 branches covered (68.45%)

Branch coverage included in aggregate %.

0 of 12 new or added lines in 1 file covered. (0.0%)

11462 of 13875 relevant lines covered (82.61%)

6.6 hits per line