tarantool / go-vshard-router / 40696163055

74%

master: 74%

Build Type

Pull #88

github

Committed by bigbes

Commit Message

api: log through *slog.Logger and stop exposing tarantool.Opts

go-tarantool v3 logs through slog, so every record that crossed into
LogfProvider had its structured attributes flattened into a formatted string
by tarantoolLogHandler. With the connector on slog and providers/slog only
existing to convert back, the interface bought nothing and cost the structure
of the logs.

Config.Loggerf becomes Config.Logger, a *slog.Logger that the pools also
receive, so router and connector events share one destination and one format.
LogfProvider, StdoutLoggerf, providers/slog and the handler go. The 35 call
sites move from Infof(ctx, format, args...) to InfoContext(ctx, msg, k, v),
which keeps the context they passed for trace ids and turns their format
arguments into attributes. An unset logger selects slog.DiscardHandler,
matching the connector, which discards logs when no logger is set.

Config.PoolOpts goes for the same reason. It was a tarantool.Opts, so it
carried four fields the v3 pool does not let a caller use: Reconnect,
MaxReconnects and Notify are rejected by pool.NewWithOpts, and Logger is
ignored now that the pool reads Config.Logger. The first three needed a
validation rule each to fail early, and the fourth was silent. Expose the six
settings the connector honours as Conn* fields instead; connOpts builds
tarantool.Opts in one place and leaves Logger unset, letting the pool copy its
own logger into each connection (pool/pool.go:887).

This is a breaking change; the module bump to /v3 is a separate change.

Pull Request Pull Request #88: deps: bump go-tarantool from v2.4.2 to v3.0.2

Coverage Stats

183 of 209 new or added lines in 5 files covered. (87.56%)

4 existing lines in 2 files now uncovered.

1191 of 1596 relevant lines covered (74.62%)

12558.09 hits per line