FlexMeasures / flexmeasures / 40691956374

87%

push

github

Record a partial group aggregate under a source naming its missing members (#2741)

* Record a partial group aggregate under a source naming its missing members

A report over a group used to blank every event that some member did not report,
so one faulty meter could hide a whole group's aggregate for as long as it stayed faulty.
Such an event is now aggregated from what reported, and recorded under a data source of its own,
whose config keeps `resolved-members` as the full membership and adds the `missing-members` it had to leave out.
The complete aggregate keeps the source it always had, so a partial aggregate can always be told apart from it.
`skip-missing: false` still leaves such events out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xg2vUMk3Sz7gitXN2FjqXJ
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Prefer a complete aggregate over a partial one of the same belief time

Picking one belief per event already lets a complete aggregate supersede a partial one,
as both sources belong to one family and the complete one is normally recorded later.
Where both carry the same belief time, as a backfill with a fixed belief time can record them,
the tie used to fall to the highest source id, which may be the partial one.
A source that names no missing members now wins such a tie.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xg2vUMk3Sz7gitXN2FjqXJ
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Show on the status page which members the latest aggregate leaves out

Whether the most recent aggregate of a group is a partial one describes the group's current state,
so it is shown on the asset's status page rather than noted in the audit log, which would grow with every run.
A reporter's status now lists the `missing_members` of the source of its most recent belief, and says so in its reason,
and the status page shows a yellow light fo... (continued)

125 of 128 new or added lines in 6 files covered. (97.66%)

22791 of 26156 relevant lines covered (87.13%)

0.87 hits per line