FlexMeasures / flexmeasures / 40681912910

87%

push

github

Note group membership changes in the group's audit log (#2723)

* data/services: note group membership changes on the group's asset

A device joins a group through its own flex-model, so the group's asset was never told.
A session listener now writes an audit log entry on the group's asset when a device joins or leaves it,
when a member moves to another site, and on the member when its group is deleted,
whichever path (API, UI, CLI, script) made the change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xg2vUMk3Sz7gitXN2FjqXJ
Signed-off-by: F.N. Claessen <felix@seita.nl>

* changelog: link PR #2723

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xg2vUMk3Sz7gitXN2FjqXJ
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Note nothing for a group ID that is no integer the database can hold, rather than failing the flush

A script or plugin may write any value as a group reference, and looking such an ID up made every insert, edit, move or delete of that asset fail,
including the edit that would repair it.

Suggested-by: Ahmad-Wahid
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xg2vUMk3Sz7gitXN2FjqXJ
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Drop the changes found before a flush that failed, rather than noting them with the next flush

The changes waiting in the session were never made, so a script that rolls back and carries on would note them anyway,
for a new member even without its ID.

Suggested-by: Ahmad-Wahid
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xg2vUMk3Sz7gitXN2FjqXJ
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Note membership changes only where the member and its group belong to one organisation

A group reference is only checked to exist, so a device could name another organisation's asset as its g... (continued)

164 of 168 new or added lines in 4 files covered. (97.62%)

22583 of 25943 relevant lines covered (87.05%)

0.87 hits per line