PeculiarVentures / attestation / 40664961848

60%

push

github

build(deps)!: move x509, asn1-schema and tsyringe to peer dependencies (#32)

The libraries take and return @peculiar/x509 objects (X509Certificate,
PublicKey), and Marvell resolves x509's algorithm provider from the global
tsyringe container and serializes asn1-x509/asn1-rsa classes with
AsnConvert, so each app needs a single copy of these packages
(see 04-dependency-strategy). common, marvell and yubico now declare
@peculiar/x509 ^3.1.0 as a peer (one floor everywhere; Marvell already
needed 3.1 for X509ChainBuilder.buildToAnchor), and marvell also
@peculiar/asn1-schema ^3.0.0 and tsyringe ^4.10.0. Each peer is repeated
in devDependencies for the workspace. @peculiar/asn1-rsa,
@peculiar/asn1-x509, pako, graphene-pk11 and the internal
@peculiar/attestation-common stay regular dependencies. The CLI is an
application and keeps everything in dependencies (x509 floor ^3.1.0).
tslib is dropped from all four packages: nothing imports it.

BREAKING CHANGE: @peculiar/x509 ^3.1.0 is a peer dependency of
@peculiar/attestation-common, -marvell and -yubico, and
@peculiar/attestation-marvell also has @peculiar/asn1-schema ^3.0.0 and
tsyringe ^4.10.0 as peers (2.0.0 depended on @peculiar/x509 ^2.0.0,
@peculiar/asn1-schema ^2.6.0 and tsyringe ^4.10.0). npm 7+ installs peers
automatically; a conflicting major now fails at install (ERESOLVE) instead
of at runtime. Apps need exactly one copy of each: Marvell resolves x509's
algorithm provider from the tsyringe container that x509 registers into,
and x509/asn1-schema keep ASN.1 schemas in module-level storage.

273 of 424 branches covered (64.39%)

Branch coverage included in aggregate %.

466 of 803 relevant lines covered (58.03%)

493.02 hits per line