solidjs / solid / 40618799182

79%

main: 89%

push

github

fix(signals): optimistic store guesses survive re-asks, answer latest() and stay per-action (#4329) (#4330)

* fix(signals): a per-key optimistic guess survives a re-ask landing while its action is pending (#4329)

A derive that writes a keyed list through its draft (`d.length = 0;
d.push(...rows)`, or `d.issues = rows`) replaced the guessed row with a
fresh object, so the guess, which lives on the old row's target, left the
screen before its action settled. The draft's new object at a guessed
row's slot (by key in a keyed list) is now adopted by that row's target,
as a reconcile landing already does: the guess stays until the commit
(D-34) and guesses on other rows stay independent (D-33).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): optimistic store corrections answer latest() and keep actions independent (#4329)

- The draft path's pairing reuses reconcile: the container above a
  guessed row reconciles the new object at its slot, so both landing
  paths share one keyed pairing and one leaf diff.
- reconcile judges a key under a guess against the guess too, so a
  truth equal to the covered value still answers it: latest() reads
  the truth, the screen keeps the guess until the commit (D-34).
- supersede no longer joins the landing's tick to the parent hold; the
  parent takes the node, and passes deriving from the held truth join
  on their own. One re-ask answering two actions' guesses no longer
  ties them together (D-33).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): raise the store scenario cap for #4329's fix

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

790 of 1078 branches covered (73.28%)

Branch coverage included in aggregate %.

1127 of 1357 relevant lines covered (83.05%)

28.39 hits per line