openconfig / ygot / 40614368455

88%

master: 89%

Build Type

Pull #1119

github

Committed by robshakir

Commit Message

ytypes, util: cache struct schema metadata and index container lookups

`retrieveNodeContainer` previously scanned all struct fields, parsed struct
tags, and called `util.ChildSchema` on every container hop. `util.ChildSchema`
also lacked an upfront `ygotAnnotation` guard and walked choice and case schema
trees for every annotation field.

Changes:
- Return `nil` immediately for `util.IsYgotAnnotation` fields in
  `util.ChildSchema`, `util.ChildSchemaPreferShadow`, and `util.childSchema`.
- Add `StructDesc` and `StructSchemaDesc` `sync.Map` caches in
  `util/schema_cache.go` for struct tags, path indices, and child schemas.
- Replace linear container scans in `ytypes/node.go` and `util/reflect.go` with
  two-segment `CandidateCursor` lookups and first-error bounds.
- Add zero-copy internal path helpers in `util` and `ytypes`, and return fresh
  slice copies from exported `util` path helpers.
- Add unit tests, wide-container benchmarks, and `5%` allocation regression
  tests in `util` and `ytypes`.

Pull Request Pull Request #1119: ytypes, util: cache struct schema metadata and index container lookups

Coverage Stats

705 of 846 new or added lines in 8 files covered. (83.33%)

31 existing lines in 4 files now uncovered.

14564 of 16476 relevant lines covered (88.4%)

1530.49 hits per line