• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeflow / trainer / 40612718872
81%

Build:
DEFAULT BRANCH: master
Ran 28 Oct 2026 01:08AM UTC
Jobs 1
Files 46
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

28 Oct 2026 01:03AM UTC coverage: 77.445% (+0.08%) from 77.366%
40612718872

push

github

web-flow
fix(api): validate OptimizationJob names and keep algorithm service names unique (#4155)

* fix(api): validate OptimizationJob names and keep algorithm service names unique

OptimizationJob had no rule on metadata.name, so the API server accepted
names the controller cannot use. A name with a leading digit made every
trial fail TrainJob validation, a name with a dot made the algorithm
Service fail, and a name over 63 characters made the Deployment fail on
its optimization-job label. None of these set a Failed condition, so the
job retried without ever running.

Apply the TrainJob name rules to OptimizationJob: an RFC 1035 label of at
most 63 characters.

GetAlgorithmServiceName cut names longer than 46 characters to 46, so
OptimizationJobs whose names share their first 46 characters got the same
Deployment and Service, and the first one to finish deleted it for the
other. Add a hash of the full name when the name is cut, so each job gets
its own algorithm service. Names of 46 characters or fewer keep the same
algorithm service name as before.

Signed-off-by: Harsh Raj <harshrajdebug@gmail.com>

* test: check algorithm service names are valid DNS-1035 labels

Signed-off-by: Harsh Raj <harshrajdebug@gmail.com>

* test: cover algorithm service name edges and check for two services

Encode only the four hash bytes that the name uses, and state the
63-character limit and the collision odds in the doc comment.

Cover the first name length that gets a hash (47) and the longest name
the API accepts (63), add the trailing-hyphen case to the name table,
and check that the shared-prefix test ends with two Deployments and two
Services.

Signed-off-by: Harsh Raj <harshrajdebug@gmail.com>

* fix(api): leave OptimizationJob name length to a separate change

Name length validation for TrainJob and OptimizationJob will be added in
a separate change, so keep only the RFC 1035 format rule here.

Move the name cases into the OptimizationJob webhook table and drop the
64-... (continued)

3 of 3 new or added lines in 1 file covered. (100.0%)

3365 of 4345 relevant lines covered (77.45%)

0.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 40612718872.1 28 Oct 2026 01:08AM UTC 46
77.45
GitHub Action Run
Source Files on build 40612718872
  • Tree
  • List 46
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • f979195a on github
  • Prev Build on master (#40606244336)
  • Next Build on master (#40613203658)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc