Kikobeats / html-scripts / 40593799807

100%

push

github

perf(parse): stream script tags with htmlparser2 instead of building a himalaya AST (#18)

* perf(parse): stream script tags with htmlparser2 instead of building a himalaya AST

himalaya tokenizes, builds a full node tree, and walks it just to find
<script> tags. htmlparser2's streaming Parser with onopentagname/onattribute
collects attributes only for script tags and builds no tree.

A/B, node benchmark/index.js, 6 alternating runs per side, median (range):

| case                 | base               | change             | delta  |
| -------------------- | ------------------ | ------------------ | ------ |
| getScripts 1MB page  | 75.1ms (72.4-77.0) | 36.0ms (35.6-36.9) | -52.1% |
| getScripts 20KB page | 72.2ms (69.6-74.2) | 45.8ms (45.3-46.2) | -36.6% |

Output changes (spec-correct, each covered by a test):
- attribute names are lowercased (<SCRIPT SRC> gave {SRC})
- entities in attribute values are decoded (&amp; stayed literal)
- unquoted values containing "/" are kept (src=/m.js gave src: true)
- scripts after a stray </script> are found (himalaya dropped them)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: boolean attributes come out as true

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(parse): keep a self-closing script's content as text

htmlparser2 leaves raw-text mode on `<script/>`, so markup inside the script
body was reported as more scripts. Tags seen while a script is open are now
ignored, as browsers do. Input is read with String() so a Buffer parses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(parse): never let template depth go negative

A template opened inside a self-closing script's text is skipped, but a
script nested in it closes the raw text first, so the template's real close
tag decremented a depth that was never incremented.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(parse): match browser script and raw-text rules

htmlparser2 ends an HTML scrip... (continued)

82 of 82 branches covered (100.0%)

Branch coverage included in aggregate %.

168 of 168 new or added lines in 1 file covered. (100.0%)

181 of 181 relevant lines covered (100.0%)

60.75 hits per line