nikic / PHP-Parser / 40575238339

93%

push

github

perf: Use local variables for parser tables in ParserAbstract::doParse() (#1182)

`ParserAbstract::doParse()` reads the action and goto tables on every
iteration of its loop, and each of those reads is a property fetch
(`$this->actionBase[...]`, `$this->actionCheck[...]`,
`$this->action[...]`, ...). In the opcode dump that is 57 `FETCH_OBJ_R`
in `doParse()`.

This PR copies the tables into local variables before the loop, the same
way `$stackPos` became a local in 3bbf8d8. The tables are written only
in the constructor and `$this->tokens` only in `parse()`, so the copies
cannot go stale. State the reduce callbacks use (`tokenPos`, `semStack`,
the token start and end stacks, `errorState`) stays on the object.

53 of 53 new or added lines in 1 file covered. (100.0%)

7809 of 8403 relevant lines covered (92.93%)

236.72 hits per line