safe-global / safe-client-gateway / 40549279600

91%

Build Type

push

github

Committed by web-flow

Commit Message

perf(transactions): decode each transaction once per request (#3703)

The transaction history, the Safe queue and the multisig transaction list decoded every transaction twice per request. `MultisigTransactionMapper.prefetchAddressInfos` decoded each transaction to collect the decoded `from`/`to` addresses for the token/contract prefetch, then threw the result away, and the mapper decoded the same transaction again to build `txInfo`. Successful decodes are not cached (`getDecodedData` sets no `expireTimeSeconds`, so only 404s are stored), so both calls reached the Decoder service.

Each call site now decodes its transactions once and passes the result to both the prefetch and the mapper. The set of transactions decoded is unchanged, and so is the response.

Decoder `POST /api/v1/data-decoder` calls per page at the default `limit=20`, counting only transactions with calldata:

| Endpoint | Before | After |
|---|---|---|
| History, first page | 40 | 20 |
| History, later pages (+1 earlier tx) | 42 | 21 |
| Safe queue, first page | 40 | 20 |
| Safe queue, later pages (+1 tx from the previous page) | 42 | 21 |
| Multisig transaction list | 2 per tx | 1 per tx |

The prefetch's decodes used to run one at a time; they now run in parallel with the rest of the page's decodes, as the mapping step already did.

`TransactionsHistoryMapper.prefetchAddressInfos` filtered with `isMultisigTransaction || isModuleTransaction`, which evaluates to `isMultisigTransaction`. It now calls `isMultisigTransaction` directly, so behaviour is the same: module transactions are still not prefetched. Including them would be a separate change.

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

4985 of 5748 branches covered (86.73%)

Branch coverage included in aggregate %.

12 of 14 new or added lines in 4 files covered. (85.71%)

2 existing lines in 2 files now uncovered.

12435 of 13502 relevant lines covered (92.1%)

358.63 hits per line