solidjs / solid / 40544651577

79%

main: 89%

push

github

fix(web): a markerless hole retags a node moved in from another slot, swap loop included (#4326)

* fix(web): a markerless hole retags a node moved in from another slot

* refactor(web): tag in reconcile's insert, one swap loop for both kinds of hole

The tag write moves into `insert`, so every place that inserts a node
tags it the same way, and the swap loop no longer splits on `marker`.
The markerless swap loop never retagged, so a node another slot had
claimed and dropped kept that slot's tag after a markerless reverse,
and a later removal left it in the DOM. Smaller, and covered by a new
test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

* reconcile: drop the stale 05_swap1k note from the swap-loop comment

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

---------

Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

790 of 1078 branches covered (73.28%)

Branch coverage included in aggregate %.

1127 of 1357 relevant lines covered (83.05%)

28.28 hits per line