gookit / config / 40539364042

97%

push

github

fix(read): parse env in Ints and IntMap before the conversion

Ints and IntMap handed the raw elem/value to mathutil.ToInt, so with ParseEnv a
"${PORT}" elem failed with "cannot convert to int", while the scalar Int, Uint,
Float and Bool read the env value through getString. Strings (#230) and StringMap
(#232) already parse env for their string elem/value, so this was the last of the
group.

- parse a string elem/value with ParseEnvValue before the conversion, through the
  new parseEnvValue helper; parseEnvString is a thin wrapper of it now.
- Ints accepts a []string value from Set, and IntMap a map[string]string one, which
  returned the "value cannot be convert" error before.
- with ParseEnv off nothing is parsed, the conversions are the same as before.

Tests: the four value shapes ([]any, []string, map[string]any, map[string]string)
with ParseEnv on, plus the no-env branch.

18 of 26 new or added lines in 1 file covered. (69.23%)

1383 of 1428 relevant lines covered (96.85%)

6.42 hits per line