Ouranosinc / xscen / 40531184548

90%

push

github

Fix DerivedCat drop (#788)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?
In #763, I modified `search_data_catalogs` so that the variable column
is "unstacked" if it is iterable. But we had some logic that expected it
to be iterable and I didn't see that.

The modified code is trying to find if any of the assets returned by
intake-esm actually contain the requested variable. If one does, the
rest is dropped and so is the DerivedVariableCatalog.

I think the need is that intake-esm might return both the variables
required to compute the requested variable and the requested variable
itself. So this takes care of that.

However, since #763, the `variable` field in the rows tested are
strings, not list. So the `var_id in v_list` check was returning false
positives in some cases. In my case, I requested "tas" with assets of
"tasmax" and "tasmin". ... And `'tas' in 'tasmax'` is True, so the wrong
decision was taken.

I changed the  `allow_conversion` test to check this.


### Does this PR introduce a breaking change?
No.

### Other information:

3 of 3 new or added lines in 1 file covered. (100.0%)

4514 of 5010 relevant lines covered (90.1%)

9.74 hits per line