optimizely / swift-sdk / 40523052414

94%

push

github

[FSSDK-12251] feat: allow custom directory for DataStoreFile and DefaultEventDispatcher (#668)

* refactor: Added optional directory parameter to DataStoreFile

* refactor: Added ability to inject file data store directory into DefaultEventDispatcher

* test: Added test for DataStoreFile custom directory

* refactor: Updated to syntax supported by Swift 5.8 and lower

* Fixed build issues

* Fixed failing test

* [FSSDK-12251] fix: keep custom data store directory API source-compatible

Rework #612 so it adds API without breaking 6.x users:
- Restore `DataStoreType.file` (no associated value) so `.file` and `==` keep compiling
- Keep `DataStoreFile.init(storeName:async:)` designated so subclasses can call super.init
- Expose the directory via new convenience inits on DataStoreFile and DefaultEventDispatcher
  (new designated inits on open classes are flagged by diagnose-api-breaking-changes)
- Add a test for the dispatcher custom-directory path

Co-authored-by: artesmichael <michael.artes@icloud.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* [FSSDK-12251] fix: create custom data store directory if missing

Application Support isn't guaranteed to exist on iOS, and Data.write
doesn't create parent directories, so writes failed and saveItem
swallowed the error, silently dropping queued events.

Resolve the directory with url(for:in:appropriateFor:create: true).
If creation fails, the store keeps its default location.

Tests no longer pre-create the directory; add a test against a
directory that doesn't exist yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: artesmichael <michael.artes@icloud.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

2 of 2 new or added lines in 2 files covered. (100.0%)

1147 of 1221 relevant lines covered (93.94%)

9431.78 hits per line