solidjs / solid / 40476701310

79%

main: 89%

push

github

fix(solid,signals): a boundary claimed after a shell write shows the client's value (#4314)

* fix(solid,signals): a boundary claimed after a shell write shows the client's value

A hydrated memo adopted while its server answer was still streaming had
no snapshot (the creation arm skips pending nodes). Since b68a907de a
shell node outside every pending boundary computes on a client write; a
streamed <Loading> that reads it and resumes afterwards then claimed its
server markup while reading the client's value, and since the claim pass
never mutates the DOM, the binding kept the server's text for good
(GH2). With the client's recompute still in flight at the resume, the
claim read the node pending and the never-revealed boundary committed
its fallback over the settled server content, detaching it and losing a
queued click (GH4).

- solid: a value node's server answer still streaming at adoption
  becomes its snapshot when it lands (readSerializedOrCompute), whether
  the node committed it or a client write had already taken the compute
  over. The claim reads what its markup shows and replays the client's
  value at the scope's release, as for a written signal.
- signals: markSnapshotScope(node, served) records that snapshot (no
  new export); a reader in a snapshot scope is served the snapshot ahead
  of the node's pending state (errored nodes still throw), so a revealed
  claim holds while the client's flight is open. takeSnapshot folds the
  three copies of the snapshot write.

Tests: hydration/claim-stale-text (signal / sync / async shell sources;
a chained pair of pending shell memos with the write before, between and
in the flush of their answers, settled or in flight at the claim — no
fallback after the fragment, no diagnostics); the generic consistency
pins GH2 and GH4 flip from test.fails to passing; signals snapshot unit
tests for the served snapshot.

Size: 0 B minified on every CSR scenario (compiled floor 9.97 KB
brotli); +61..69 B minified... (continued)

790 of 1080 branches covered (73.15%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

1123 of 1353 relevant lines covered (83.0%)

28.04 hits per line