safe-global / safe-client-gateway / 40475266710

91%

push

github

fix(chains): accept only digit strings as chain IDs (#3632)

* fix(chains): accept only digit strings as chain IDs

ChainIdSchema accepted any string that Number() parses, such as -1, 1.5 or 1e3. Such a value passed validation and then failed in the chain lookup with a generic 404. It now fails validation with a 422 on every route that uses the schema.

* refactor(chains): validate chain IDs with one digits refine

The digits rule already implies the numeric-string check, so the schema needs no guard. The issue keeps code 'custom' and the existing message.

4984 of 5748 branches covered (86.71%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

12435 of 13501 relevant lines covered (92.1%)

355.24 hits per line