ponder-lab / Hybridize-Functions-Refactoring / #3857

89%

main: 90%

push

github

Refuse a function that reshapes with a shape that may be a scalar (#1177)

* Build against the engine snapshot carrying ponder-lab/ML#1091

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Refuse a function that reshapes with a shape that may be a scalar

Eagerly, `tf.reshape(t, -1)` works, but graph shape inference requires a
rank-1 shape operand, so the converted function raises on its first trace
(#1170). The new RESHAPES_WITH_SCALAR_SHAPE precondition refuses the
conversion when a reachable call to `tf.reshape`, as the engine names it,
has a shape operand the engine reports may be rank 0. An operand of
unknown rank still converts.

The check walks the call graph the way the eager-only-call check does,
through a walk moved out of `EagerOnlyCallAnalysis` into
`Util.reachesInstruction`, which both now share.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Give each unknown-rank reshape witness its own cause

A computed int waits on wala/ML#1149 and `len` on wala/ML#1104. A
starred argument is of unknown rank by design, so it carries no TODO.
Also rewrap two comments that broke mid-sentence.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Refuse a reshape by the result of `len`

With wala/ML#1104 on the engine snapshot, `ShapeOperandRank` reads an
int of unknown value as rank 0, so the shape operand of
`tf.reshape(x, len(xs))` may be rank 0 and the function is refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Point the computed-int reshape TODO at its HFR issue

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Refuse a reshape by a comp... (continued)

42 of 46 new or added lines in 6 files covered. (91.3%)

5768 of 6446 relevant lines covered (89.48%)

0.89 hits per line