umputun / reproxy / 40461204219

81%

push

github

fix: keep range responses intact under gzip, add --gzip-exclude (#266)

* fix: keep range responses intact under gzip, add --gzip-exclude

With --gzip on, compression ignored the response type and range headers. A 206
could go out gzipped while Content-Range described the raw bytes, which broke
range and resumed downloads, and already compressed media was compressed again
for no gain.

The decision is now made from the final response headers. Partial responses,
responses that already carry Content-Encoding and media types matching
--gzip-exclude are sent as is. The client's Accept-Encoding is forwarded so an
upstream's own encoding passes through, and an existing strong ETag is weakened
when reproxy compresses. HEAD keeps the encoding headers without advertising
the length of an empty compressed stream.

* fix: send zlib-framed bodies for deflate content-encoding

HTTP "deflate" means the zlib format, but the deflate path wrote a raw deflate
stream, so clients with a strict decoder rejected responses labeled deflate.
The writer is now compress/zlib, and the tests decode deflate with zlib.

* docs: note that writers inside the access log must not expose ReadFrom

* fix: let an aborted upstream body reach the client as truncated

When an upstream body read failed, rest.Recoverer swallowed
http.ErrAbortHandler and appended 500 text to the committed response. Chunked
and locally compressed responses could then finish cleanly, hiding the
truncation.

go-pkgz/rest v1.24.0 re-panics the sentinel so net/http can abort the response.
The gzip writer is now closed only on a normal return, leaving an aborted
response unfinished. The bump also brings testify v1.12.0, which rest
v1.24.0 requires.

134 of 143 new or added lines in 3 files covered. (93.71%)

2814 of 3499 relevant lines covered (80.42%)

84.76 hits per line