dmeoli / ADS / 40437160202

98%

main: 98%

push

github

Lyndon, rANS and LCS: three defects found while documenting

- lyndonFactorization() and leastRotation() compare the bytes as
  unsigned, as std::string_view and isLyndon() order them: from 0x80 on,
  where char is signed, the factors and the rotation were wrong and the
  audits failed
- ransDecompress() stops a malformed stream before its reads pass the 8
  bytes of padding, at one comparison every four symbols, and rejects it
- lcsMemo() runs the recursion on a stack of its own, as it goes m + n
  calls deep and exhausted the stack on long strings; the duplicated
  include of <algorithm> is gone
- the tests lyndon-bytes, rans-corrupted and lcs-long

26 of 26 new or added lines in 3 files covered. (100.0%)

41580 of 42620 relevant lines covered (97.56%)

10594595.54 hits per line