nocarryr / python-dispatch / 40441949300

98%

push

github

Return native values from ObservableDict.pop and setdefault (#126)

`DictProperty` values inherit dictionary methods, but the observable
wrappers discard the results of `pop()` and `setdefault()`. For example,
popping an existing value returns `None`, and callers cannot use the
object returned by `setdefault()`.

Return the native dictionary result after emitting the existing
notification. Add regression tests for removed values, missing-key
fallbacks, inserted/existing defaults, object identity, exceptions, and
both `copy_on_change` settings. Existing notification counts and
old-value snapshots are checked. Document the changed methods and tests.

Validation on Windows / Python 3.12.14 with the frozen upstream test/doc
dependencies:

- Four new regression cases fail before the fix and pass after it.
- `pytest --cov --cov-config=.coveragerc -p no:cacheprovider tests
pydispatch doc README.md`: 57 passed.
- Sphinx plugin suite: 8 passed using a fresh explicit `--basetemp` and
network access for ReadTheDocs inventories; Sphinx/dependency warnings
remain.
- Combined coverage: 97%; `git diff --check` passes.

Earlier Sphinx attempts encountered inaccessible system temp files and
blocked network access. A fresh workspace temp directory with network
access passed. The upstream Linux/Python-version matrix needs maintainer
approval before GitHub Actions can run.

AI-assisted investigation, implementation and test execution with Codex.

4 of 4 new or added lines in 1 file covered. (100.0%)

834 of 852 relevant lines covered (97.89%)

6.61 hits per line