openconfig / ygot / 40429050011

89%

master: 89%

Build Type

Pull #1115

github

Committed by robshakir

Commit Message

ygot: remove repeated JSON normalisation in RFC7951 rendering

`structJSON` previously called `normalizeJSONValue` -- which runs
`json.Marshal` and `json.Unmarshal` -- on every container and list. That
round-trip serialised and parsed every leaf value once per ancestor
container rather than once per tree.

Changes:
- Remove `normalizeJSONValue` calls from `structJSON` and `jsonValue` in
  `ygot/render.go`.
- Update `writeIETFScalarJSON` to return the Go primitive types (`string`,
  `float64`, `bool`) that `encoding/json.Unmarshal` decodes into `any`.
- Skip `nil` map, slice, pointer, and interface fields at the start of
  `structJSON` before parsing struct tags.
- Pre-size output slices in `leaflistToSlice`, `mapValuePairsToJSON`,
  `mapJSON`, `jsonSlice`, and `jsonAnnotationSlice`.
- Add type-parity and `5%` allocation regression tests
  (`TestConstructIETFJSONTypeParity` and `TestRFC7951JSONPerformance`) in
  `ygot/render_test.go`.

Pull Request Pull Request #1115: ygot: remove repeated JSON normalisation in RFC7951 rendering

Coverage Stats

60 of 77 new or added lines in 1 file covered. (77.92%)

6 existing lines in 1 file now uncovered.

14180 of 15990 relevant lines covered (88.68%)

1617.5 hits per line