openconfig / ygot / 40429042492

88%

master: 89%

Build Type

Pull #1118

github

Committed by robshakir

Commit Message

ytypes, util: guard debug string formatting when logging is disabled

`util` and `ytypes` previously evaluated `pretty.Sprint` and `Schema.Path`
arguments before calling `util.DbgPrint` and `util.DbgSchema`, even with
debug logging disabled. In `unmarshalKeyedList`, this formatted the growing
map on every entry and caused `O(n^2)` heap allocations.

Changes:
- Add `IsDebugLibraryEnabled` and `IsDebugSchemaEnabled` helpers in
  `util/debug.go`.
- Check `debugLibrary` in `util.DbgErr` before concatenating error strings.
- Guard `DbgPrint` and `DbgSchema` calls that allocate arguments in
  `util/reflect.go` and
  `ytypes/{container,int_type,leaf,leafref,list,util_schema}.go`.
- Add unit and `5%` allocation regression tests (`TestDebugEnabledHelpers`,
  `TestDbgErr`, and `TestUnmarshalKeyedListPerformance`) in
  `util/debug_test.go` and `ytypes/unmarshal_test.go`.

Pull Request Pull Request #1118: ytypes, util: guard debug string formatting when logging is disabled

Coverage Stats

31 of 78 new or added lines in 8 files covered. (39.74%)

6 existing lines in 1 file now uncovered.

14126 of 15968 relevant lines covered (88.46%)

1591.71 hits per line