openconfig / ygot / 40428056531

89%

master: 89%

Pull #1116

github

ygot: handle GoOrderedMap fields in PruneEmptyBranches

TLDR: ygot.PruneEmptyBranches previously treated GoOrderedMap pointers as
regular GoStruct pointers and panicked on their unexported fields. This change
handles GoOrderedMap fields explicitly so PruneEmptyBranches removes empty
ordered maps and recurses safely into populated entries.

Problem Statement:
- Generated YANG ordered-by user lists implement ygot.GoOrderedMap on a struct
  pointer that holds unexported keys and valueMap fields.
- In ygot/struct_validation_map.go, pruneBranchesInternal checked
  util.IsTypeStructPtr before checking GoOrderedMap.
- When a GoOrderedMap field held entries -- or retained empty slices after
  Delete -- pruneBranchesInternal recursed into the struct.
- pruneBranchesInternal then called reflect.Value.Interface on unexported
  fields and panicked at runtime.

Proposed Solution:
- Check GoOrderedMap in pruneBranchesInternal before the regular struct pointer
  branch in ygot/struct_validation_map.go.
- Skip nil GoOrderedMap fields without changing allChildrenPruned.
- Set empty GoOrderedMap fields (Len() == 0) to nil so pruneBranchesInternal
  also removes empty parent containers.
- Set allChildrenPruned = false for non-empty GoOrderedMap fields and iterate
  their entries with yreflect.RangeOrderedMap to prune empty child branches.
- Add TestPruneEmptyBranchesOrderedMap in
  ygot/struct_validation_map_exported_test.go to test nil, empty, deleted,
  nested, compressed, and uncompressed GoOrderedMap cases.

19 of 21 new or added lines in 1 file covered. (90.48%)

14167 of 15958 relevant lines covered (88.78%)

1522.01 hits per line