kubeflow / trainer / 40425961393
78%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 45
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 77.261% (-0.07%) from 77.331%
40425961393

push

github

web-flow 
chore(test): add Open MPI 4 e2e for the MPI runtime (#4282)

* chore(test): add Open MPI 4 e2e for the MPI runtime

The DeepSpeed and MLX images ship Open MPI 5, so no e2e covered the OMPI_MCA_orte_* env vars anymore. Run the deepspeed-distributed layout with the Open MPI 4 mpi-pi image from kubeflow/mpi-operator and check that mpirun reaches both hosts.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>

* chore(test): run the OpenMPI e2e as a table over images

Share one test body between the DeepSpeed image and the Open MPI 4 image instead of duplicating it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>

* chore(test): drop the Open MPI 4 image comment

Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>

* chore(test): set the Open MPI 4 image on the TrainJob in the MPI e2e

spec.trainer.image now reaches the MPI launcher and nodes (#4301), so the Open MPI 4 entry sets the image on the TrainJob instead of copying the deepspeed-distributed runtime with the image on every replicatedJob.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>

* simplify test cases

Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>

---------

Signed-off-by: Matteo Bunino <48362942+matbun@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

3306 of 4279 relevant lines covered (77.26%)

0.78 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
72.0
-12.0% pkg/runtime/core/core.go
Jobs
ID Job ID Ran Files Coverage
1 40425961393.1 45
77.26
GitHub Action Run
Source Files on build 40425961393