openconfig / ygot / 40421798323

89%

master: 89%

Build Type

Pull #1115

github

Committed by robshakir

Commit Message

ygot, ytypes: eliminate recursive JSON normalisation and eager debug allocations

- ygot/render.go, ygot/struct_validation_map.go:
  - Remove recursive normalizeJSONValue (json.Marshal + json.Unmarshal) at
    every container depth in structJSON and jsonValue, reducing RFC7951
    rendering from O(Depth * TreeSize) to O(TreeSize).
  - Add normalizeScalars to jsonOutputConfig: enabled for ConstructIETFJSON
    and MergeStructJSON so writeIETFScalarJSON normalises scalars directly to
    encoding/json.Unmarshal Go types (float64, string, bool) without JSON
    round-trips; disabled for Marshal7951, EncodeTypedValue, and EmitJSON
    where encoding/json serialises the intermediate map directly to bytes.
  - Skip nil Map/Slice/Ptr/Interface fields at the start of structJSON before
    stype.Field(i), prependmodsJSON, and structTagToLibPaths.
  - Pre-size output slices in leaflistToSlice, mapValuePairsToJSON, mapJSON,
    jsonSlice, and jsonAnnotationSlice.
- util/debug.go, util/reflect.go, ytypes/*.go:
  - Add util.IsDebugLibraryEnabled() and util.IsDebugSchemaEnabled(), and
    guard string concatenation in util.DbgErr when debugLibrary is false.
  - Guard eager debug argument evaluations (including O(N^2) pretty.Sprint
    in unmarshalKeyedList, pretty.Sprint(destv.Interface()) and per-field
    dataTreePaths in unmarshalStruct, pretty.Sprint(value) in
    InitializeStructField, and ni.Schema.Path() in dataNodesAtPath) behind
    debugLibrary / debugSchema checks.
- Add ConstructIETFJSON type-parity tests and 5% testing.AllocsPerRun
  regression gates with benchmarks in util, ytypes, and ygot.

Pull Request Pull Request #1115: ygot, ytypes: eliminate recursive JSON normalisation and eager debug allocations

Coverage Stats

138 of 220 new or added lines in 10 files covered. (62.73%)

14 existing lines in 3 files now uncovered.

14199 of 16080 relevant lines covered (88.3%)

1678.23 hits per line