solidjs / solid / 40418061305

79%

main: 89%

push

github

feat(babel-plugin): support @babel/core 8 alongside 7 (#4309)

* feat(babel-plugin): support @babel/core 8 alongside 7

Widen the @babel/core peer to ^7.20.12 || ^8.0.0. Babel 8 is npm's
`latest`, so a direct Babel 8 setup (e.g. babel-jest 30) hit a peer
conflict.

- ssr/props: read Scope#uidsSet when present; Scope#uids throws on 8.
- dom/element: t.jSXExpressionContainer alias (removed in 8) renamed.
- Evaluated numbers use t.valueToNode; numericLiteral rejects negative
  and non-finite values in @babel/types 8.
- Fixture harness pins jsescOption.minimal=false so snapshots match on
  both majors; insertChildren fixtures parenthesize the JSX comma
  expression, which Babel 8's parser rejects bare.
- CI: new babel-8 job runs the plugin suite against @babel/core 8.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ReWJXCS5UoZC6vZ8vmQGJW

* fix(babel-plugin): Babel 8 ImportExpression and TSRX AST shapes

- isDynamic / callsOutsideFunctions treat `ImportExpression` like a call,
  so `<Show>{import("./x")}</Show>` stays lazy when `import()` parses as
  ImportExpression (Babel 8, or 7 with createImportExpressions). Matched
  by node type, not a visitor key, so cores older than 7.23 still load.
- TSRX's ESTree-to-Babel pass targets the running core's major (from
  `api.version`): Babel 8 keeps `typeArguments`, Identifier type
  parameter names, `ImportExpression`, `TSEnumBody`, `TSImportType.source`,
  `TSInterfaceHeritage` / `TSClassImplements` and `superTypeArguments`.
  Fixes the generator crash on `function id<T>()` and dropped
  `make<number>()` type arguments under Babel 8.
- TSRX no longer drops `import()` options or class method type
  parameters (both majors).
- Tests: import-expression.spec.js, and tsrx-babel-ast.spec.js, which
  compares TSRX ASTs with the installed core's own TypeScript parse, so
  the babel-8 CI job checks the Babel 8 shapes.

Co-Authored-By: Claude Opus 5.5 <... (continued)

785 of 1074 branches covered (73.09%)

Branch coverage included in aggregate %.

1120 of 1350 relevant lines covered (82.96%)

27.85 hits per line