stacklok / toolhive / 40366147337

73%

Build Type

push

github

Committed by web-flow

Commit Message

Show upstream display name on consent page (#6929)

* Show upstream display name on consent page

The consent page's "You will sign in with" line showed the upstream's
Name, a routing and storage key restricted to DNS-label syntax. An
embedder keying upstreams by an opaque id showed that id to users.

Add an optional, display-only DisplayName to UpstreamRunConfig,
UpstreamConfig and NamedUpstream (closes #6922):
- Copy it through buildUpstreamConfig and buildUpstreams
- Resolve it at render time from the current upstream list, sanitised
  like client names, trimmed and capped; fall back to Name
- Keep Name in Technical details and as every storage key
- Never reject it in validation
- Document the trust obligation and regenerate API docs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Address code review feedback

Fixed issues from code review:
- MEDIUM: Move display-name validation test above the
  UpstreamFilter test's doc comment

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Tighten consent label truncation and tests

Addresses stacklok/toolhive#6929 review comments:
- LOW consent_test.go (4360871334): pin empty DisplayName on a configured upstream
- LOW consent_test.go (4360871388): add authorize-path and multi-upstream test
- LOW consent_test.go (4360871393): narrow AC1.3 test to the lookups it guards
- LOW consent.go (4360871419): trim space before the ellipsis, fix cap comment
- LOW consent_test.go (4360871425): add cap, ampersand and quote rows
- LOW consent.go (4360871438): reword "swapped upstream set" comment
- LOW consent.go (4360871447): rename cap to maxConsentTextRunes
- LOW consent.go (4360871456): return from inside the upstream loop
- LOW consent_test.go (4360871486): assert pending record consumed, add helper

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Pin display_name encoding and runner validation

Addresses stacklok/toolhive#6929 review comments:
- MEDIUM config_test.go (4360871381): add ... (continued)

Coverage Stats

24 of 24 new or added lines in 3 files covered. (100.0%)

60 existing lines in 3 files now uncovered.

89578 of 124723 relevant lines covered (71.82%)

128.45 hits per line