safe-global / safe-client-gateway / 40345376364

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(counterfactual-safes): match omitted payment fields to zero (#3676)

* fix(counterfactual-safes): match omitted payment fields to zero

The add-network flow replays a Safe's creation from a deployed chain and
submits paymentToken = zero address and payment = "0", while the original
creation omitted both and they were stored as null. Clients encode an
omitted payment token and payment as zero in the setup call, so both forms
predict the same address, but the strict comparison rejected the replay as
a collision with a 409.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(counterfactual-safes): check each init-param collision field alone

Merge the threshold collision test and the non-zero payment test into one
it.each that changes a single field per case: the threshold, the payment
token, or the payment. The old payment test changed both payment fields
at once, so a bug in one helper could be hidden by the other.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

4973 of 5740 branches covered (86.64%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

12428 of 13497 relevant lines covered (92.08%)

358.75 hits per line