AlexandreDecan / portion / 40313776327

98%

push

github

Fix IntervalDict.combine dropping pieces of the domain intersection (#115)

* Fix IntervalDict.combine dropping intersection pieces

The sweep introduced in 8db341e iterates d.items() (non-atomic keys) and can advance past a later key that fills an interior gap of an earlier non-atomic key (e.g. a singleton inside a union), silently dropping those points from the combined result. Iterate globally sorted atomic pieces on both sides instead.

* Remove trailing blank line

* Remove trailing blank line

* Add regression test for combine with non-atomic key and interior piece

Added a test for combining non-atomic intervals with interior pieces in the IntervalDict class.

* Invoke how once per intersecting key pair with the union of the intersection

* Add regression tests for pass_interval with non-atomic keys

* Restore the pairwise intersection loop for combine

6 of 6 new or added lines in 1 file covered. (100.0%)

730 of 742 relevant lines covered (98.38%)

4.92 hits per line