FEniCS / ffcx / 40291595106

89%

Build Type

push

github

Committed by web-flow

Commit Message

Enable sum factorisation by default and improve O2 kernel generation (#906)

* Fix sum factorisation with several or one point quadrature rules

- 1D tensor factor tables were named FE_TF0, FE_TF1, ... from zero for
  each quadrature rule, so the tables of integrals with different
  quadrature degrees clashed and one rule read the other's tables, giving
  a wrong element tensor. Include the quadrature rule in their name.
- A piecewise table with tensor factors, such as a coefficient on a one
  point rule, is accessed outside the quadrature loop, where the
  quadrature index can't be split by direction, which failed an
  assertion. Its factors are constant over the points, so read point 0.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Make quadrature weights tensor products

* Add opt-in sum-factorised contraction for tensor product cell integrals

With `sum_factorization_contraction`, cell integrals on tensor product
rules cache the integrand on the whole rule and contract one direction at
a time, instead of updating every element tensor entry at every quadrature
point: O(N^2 Q^2 + N^4 Q) rather than O(Q^2 N^4) in 2D, and O(N^6 Q)
rather than O(Q^3 N^6) in 3D.

- The 1D quadrature weights are folded into the first argument's 1D
  tables at code generation time.
- Terms with the same dof loops share one loop nest; stage arrays and
  contributions shared by several terms are computed once, and each
  element tensor entry is updated once.
- Integrals whose buffers exceed a 256 KiB stack budget, or with an
  argument that doesn't factorise, keep the fused loop.
- Without the option, kernels use the fused loop with the full weights
  table, as before 59e849d6.
- Tensor factor tables are indexed by their own single permutation and
  entity.
- Unread element tables are pruned when the contraction is used.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Plan sum-factorised contractions once and declare only ... (continued)

Coverage Stats

425 of 426 new or added lines in 11 files covered. (99.77%)

13 existing lines in 4 files now uncovered.

5209 of 5858 relevant lines covered (88.92%)

0.89 hits per line