solidjs / solid / 40286392855

79%

main: 89%

push

github

feat(web): keep focus on a moved node with moveBefore() (#3997) (#4261)

* feat(web): keep a moved node's state with moveBefore() (#3997)

List reconciliation and array inserts move a node already in the document
with Element.moveBefore() where the browser has it, so focus and other
connection-bound state survive the move. The reconcile's replaceChild path
no longer detaches a row it places again later in the pass: with
moveBefore() the row waits at the region's end until its turn. Browsers
without moveBefore() behave as before; its extra preconditions fall back
to insertBefore().

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DnnXqdbCEVD67nWJbZ2Myv

* perf(web): limit moveBefore() to the node holding focus (#3997)

moveBefore() for every connected node made whole-list reorders 4-8%
slower once layout ran. Only the node containing document.activeElement
now moves with moveBefore(); the reconcile's replaceChild path parks a
row only while focus is in the list. Everything else keeps insertBefore().

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DnnXqdbCEVD67nWJbZ2Myv

* test(web): shrink the moveBefore fuzz to fit CI's 5 s test timeout

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DnnXqdbCEVD67nWJbZ2Myv

* perf(web): skip the focus check on the replaceChild path without moveBefore()

The reconcile's replaceChild path read document.activeElement even in
browsers without moveBefore(), where parking the row can't keep focus
anyway. CodSpeed's jsdom shuffle bench caught it (-5%).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DnnXqdbCEVD67nWJbZ2Myv

* perf(web): golf the moveBefore() path

Check that both ends are connected instead of catching moveBefore()'s
throw, and shar... (continued)

771 of 1066 branches covered (72.33%)

Branch coverage included in aggregate %.

1114 of 1358 relevant lines covered (82.03%)

27.71 hits per line