Gallopsled / pwntools / 40278763752

74%

dev: 0%

Build Type

push

github

Committed by web-flow

Commit Message

gdb.corefile: Run gdb directly to prevent detach race (#2787)

* gdb.corefile: Run gdb directly to prevent detach race

`attach()` waits for the debugger to attach by polling the `TracerPid` regularly. `corefile()` runs `detach` in gdb after dumping the core, so the debugger might attach and detach between two `TracerPid` polls and `wait_for_debugger()` thinks gdb exited before attaching and returns `None` as gdb's pid is no longer valid.

Later `corefile()` ran `psutil.Process(pid).wait()` with `pid = None` which effectively waited on the Python process itself to exit.
This caused a hang in the doctest CI sometimes, which was killed by the watchdog timer eventually.

Run `gdb` directly and just observe the exit code instead of relying on the more advanced `attach` logic for longer running debug sessions.

* Update CHANGELOG

Coverage Stats

3821 of 6434 branches covered (59.39%)

7 of 9 new or added lines in 1 file covered. (77.78%)

4 existing lines in 2 files now uncovered.

13337 of 18131 relevant lines covered (73.56%)

0.74 hits per line