visgl / deck.gl / 40270147639

85%

push

github

fix(core): release shadow resources when LightingEffect turns shadows off (#10891)

EffectManager reuses the existing LightingEffect and calls setProps when
a new one is passed. Turning the last `_shadow` light off kept the
shadow module registered as a default module, but getShaderModuleProps
stopped passing the dummy shadow map, so shadow_uShadowMap0/1 were
unbound and every layer skipped drawing. Call cleanup() from setProps
when no light casts shadows, so layers are rebuilt without the module.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

9859 of 12221 branches covered (80.67%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

16317 of 18882 relevant lines covered (86.42%)

27795.66 hits per line