umputun / tg-spam / 40217024594

85%

push

github

fix(config): decode --confdb blobs over the defaults (#461)

* fix(config): decode --confdb blobs over the defaults

a key missing from a stored blob loaded as zero, and ApplyDefaults leaves
zero-aware paths alone, so a partial blob written outside tg-spam got
meta.links_limit and meta.mentions_limit at 0 (every link or mention is
spam) and six other settings disabled instead of their defaults.

the store now decodes the blob over the CLI-default template at startup
and on /config/reload, so an absent key takes its default while a key
stored as zero keeps it. blobs tg-spam writes itself carry every key and
load unchanged.

Related to #460

* refactor(config): build the confdb settings store in one place

startup and POST /config/reload built their settings stores separately,
so nothing tied the reload store to the seeded load. makeSettingsStore
now builds both, always with the defaults seed, and is tested directly.

* docs(backlog): record CAS and min-msg-len zero-aware registration

* docs(backlog): record reload replacing a missing instance_id

23 of 35 new or added lines in 3 files covered. (65.71%)

8725 of 10342 relevant lines covered (84.36%)

193.02 hits per line