adybbroe / activefires-pp / 40192776655

75%

main: 75%

Pull #36

github

Handle polygon holes and boundaries correctly in fire filtering

Replace the previous exterior-ring-only point-in-polygon handling with
Shapely geometry predicates so spatial filtering respects full polygon
geometry.

Use `covers()` for point inclusion checks, which gives the intended
operational behaviour:

- points inside a polygon are included
- points inside polygon holes are excluded
- points on polygon boundaries are included
- the same semantics apply to both Polygon and MultiPolygon geometries

This fixes the previous behaviour where interior rings were ignored and
points inside holes could incorrectly be classified as inside the
polygon.

Add regression tests for polygon interiors, holes, exterior boundaries,
vertices, and points outside the geometry.

The boundary policy is intentionally simple and deterministic. Given
the native VIIRS spatial resolution, treating points on polygon
boundaries as inside avoids introducing sub-pixel distinctions that are
not physically meaningful.

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>

211 of 348 branches covered (60.63%)

1019 of 1357 relevant lines covered (75.09%)

2.99 hits per line