decentraland / marketplace / 40169589335

68%

master: 68%

Build Type

Pull #2742

github

Committed by decentraland-bot

Commit Message

fix: keep the collection filter when its collection can't be found

SelectFilter falls back to the first option when fetchOptionFromValue finds
nothing for the current value. CollectionFilter renders it with no options,
so the fallback read `.value` of undefined inside an async effect and the
rejection went unhandled (Sentry MARKETPLACE-17C, TypeError: Cannot read
properties of undefined (reading 'value'), culprit SelectFilter effect).

It shows up on /campaign: the campaign badge links with onlyOnSale=true and
the tagged contracts, and when the first contract has nothing on sale the
lookup returns null.

- Fall back to the first option only when there is one; otherwise keep the
  value, which may come from a link that set the filter on purpose.
- Catch a failing lookup and always reset the loading state.
- Ignore a lookup that was superseded, and append the found option with a
  functional update.

Sentry: https://decentraland.sentry.io/issues/7387933289/

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Pull Request Pull Request #2742: fix: keep the collection filter when its collection can't be found

Coverage Stats

4589 of 8409 branches covered (54.57%)

Branch coverage included in aggregate %.

9 of 10 new or added lines in 1 file covered. (90.0%)

11 existing lines in 1 file now uncovered.

10042 of 13139 relevant lines covered (76.43%)

119.78 hits per line