openconfig / ygot / 40146802462

89%

Build Type

push

github

Committed by web-flow

Commit Message

ytypes: refactor retrieveNodeList and optimise concrete list lookups to O(1) (#1112)

* ytypes: refactor retrieveNodeList and optimize concrete list lookups to O(1)

Proposed alternative implementation to #1111 addressing review comments in https://github.com/openconfig/ygot/pull/1111#pullrequestreview-5582738295:

* **`ytypes/node.go`**:
  - Split `retrieveNodeList` into upfront validity checks and a `switch` via `isWildcardListQuery` dispatching to `retrieveNodeListWildcard` vs. `retrieveNodeListConcrete`.
  - Handle `rv.Len() == 0` upfront in both `retrieveNodeListConcrete` (inserting directly via `insertAndRetrieveNodeList` when `args.modifyRoot` is set, and returning `nil, nil` otherwise) and `retrieveNodeListWildcard`.
  - Replace the chained `else if rv.Len() > 0` with an explicit `switch` on `listKeyT` (`util.IsTypeStruct`, `util.IsTypeInterface`, `default`).
  - Handle `StringToType` errors immediately at the call site by returning `codes.InvalidArgument`, rather than ignoring `err != nil` and falling through to full-map iteration.
  - Extend $O(1)$ `rv.MapIndex` lookup to concrete multi-keyed lists (`retrieveNodeListConcreteStructKey`) in addition to single-keyed lists.
  - Deduplicate list-element delete/prune and insert-and-recurse logic into `retrieveNodeListElem`, `insertAndRetrieveNodeList`, and `structKeyFields`.
* **`ytypes/util_types.go`**:
  - Extend `StringToType` to handle `reflect.Float64` (`decimal64` keys, rejecting non-finite `NaN`/`Inf`) and `.Convert(t)` on `reflect.String` and `reflect.Bool` (for defined types such as `YANGEmpty`).
* **`ytypes/node_test.go`, `ytypes/util_test.go`**:
  - Add unit tests covering `StringToType`, concrete/wildcard single-key and multi-key lookups, `decimal64` and wrapper-union keys, immediate `InvalidArgument` errors on malformed keys, `GetOrCreateNode` on union-keyed lists, and batch-delete transitory states.
  - Add `SetNode` and `GetNode` benchmarks for single-keyed and multi-keyed lists (`n... (continued)

Coverage Stats

213 of 235 new or added lines in 2 files covered. (90.64%)

9 existing lines in 3 files now uncovered.

14137 of 15928 relevant lines covered (88.76%)

1524.63 hits per line