stephenafamo / bob / 40134872058

53%

main: 53%

Build Type

Pull #786

github

Committed by Roman A. Grigorovich

Commit Message

fix(psql): preserve FROM/USING placeholder offsets

UPDATE and DELETE passed start+len(args) into writeFromItemList, which
added len(args) again when expressing each from_item, so preceding
arguments were double-counted and placeholder numbers skipped (e.g.
$5,$6 instead of $3,$4 after two SET arguments).

Refactor the helper into expressFromItems following the bob.Express*
conventions: it no longer takes the accumulated args slice and returns
only the newly generated arguments, with callers appending them
explicitly.

Fixes #772

Pull Request Pull Request #786: fix(psql): preserve FROM/USING placeholder offsets (Fixes #772)

Coverage Stats

5 of 5 new or added lines in 3 files covered. (100.0%)

7 existing lines in 1 file now uncovered.

12321 of 23154 relevant lines covered (53.21%)

733.74 hits per line