• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Eyevinn / mp4ff / 40095212650
83%
master: 85%

Build:
Build:
LAST BUILD BRANCH: fix/crop-tables
DEFAULT BRANCH: master
Ran 24 Oct 2026 12:45PM UTC
Jobs 1
Files 221
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Oct 2026 12:44PM UTC coverage: 83.037% (+0.04%) from 82.993%
40095212650

Pull #669

github

tobbee
fix(mp4): return errors instead of panicking in the crypto entry points

InitProtect and ExtractInitProtectData read the sample description of the
track through mdia, minf, stbl and stsd, and the trex through mvex, without
checks. DecryptInit did the same for every track, and also read its tkhd. A
moov without mvex, or a track that lacks one of those boxes, made them
panic. A missing box on the way to the sample description, or a missing tkhd
in DecryptInit, now gives an error. A moov without mvex gives no trex, as an
mvex without trex already did.

ExtractInitProtectData took the sinf of every sample entry without checking
that it exists, so it panicked on a clear init segment. It now skips sample
entries without sinf, and returns an error if none has one, or if the sinf
lacks frma (for video), schm or tenc. Without tenc, cbcs encryption with the
returned data would panic later.

InitProtect and ExtractInitProtectData passed the avcC, hvcC or av1C of the
sample entry to the protector factories without checking it. A sample entry
without its decoder configuration box now gives an error. The callers make
the check, so the protector factories, which open PR #665 changes, stay as
they are.

VisualSampleEntryBox.RemoveEncryption and
AudioSampleEntryBox.RemoveEncryption read the data format of the frma box
without checking it, after they had removed the sinf. They now return an
error for a sinf without frma before they change the sample entry.
DecryptInit, which calls them, also read the scheme type of a sinf without
schm.

DecryptFragmentWithKeys, which DecryptSegment, DecryptSegmentWithKeys and
DecryptFragment call, read the schm, schi and tenc of the sinf of the track
without checks, and now returns an error if one is missing. It also read the
start position of the mdat of every fragment, which panicked for a fragment
without mdat whose tracks are all clear.

The cases were found by renaming one box type to free in testdata files, or
removing the box fr... (continued)
Pull Request #669: fix(mp4): return errors instead of panicking in the crypto entry points

99 of 104 new or added lines in 3 files covered. (95.19%)

24261 of 29217 relevant lines covered (83.04%)

0.83 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
82.69
1.54% mp4/crypto.go
Jobs
ID Job ID Ran Files Coverage
1 40095212650.1 24 Oct 2026 12:45PM UTC 221
83.04
GitHub Action Run
Source Files on build 40095212650
  • Tree
  • List 221
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #669
  • PR Base - master (#40095181224)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc