collective / icalendar / 40085546747

98%

push

github

Add vRequestStatus (#1792)

* Add vRequestStatus

* Hand jcal parsing over from vText to vRequestStatus

* test special case of only status code

* Add doctest example

* redirect jcal parsing, test adding to component

* Improve coverage of TypesFactory

* Test code path of not having a match

* Test jCal edge cases of vRequestStatus

See https://github.com/collective/icalendar/pull/1792#discussion_r4040271630

* Remove print from tests

* Correct typing and documentation

* Apply suggestion from @stevepiercy

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* Apply batched suggestions from code review

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* stricter code regex

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* Sticter RFC grammar for request status code

This also adds validation of types and values to new()

* make first ; mandatory

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* Apply batched suggestions from code review

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* Test xCal conversion

* Document design decision on strictness

* add docs stubs

* Add examples and fix test

* Use Unicode arrows

* Example inside property

* Update glossary

* Use sentence with .

* Add plurals

* Apply batched suggestions from code review

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* Correct links in glossary and add ,

* Update docs/explanation/api-design.rst

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* Update docs/explanation/api-design.rst

Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>

---------

Co-authored-by: Steve Piercy <web@stevepiercy.com>

2023 of 2180 branches covered (92.8%)

Branch coverage included in aggregate %.

258 of 262 new or added lines in 8 files covered. (98.47%)

17778 of 18051 relevant lines covered (98.49%)

6.89 hits per line