mathieuprog / polymorphic_embed / 44b1449e6d2c12d65d28681206a374d0a3cb0479-PR-148

86%

master: 83%

Build Type

Pull #148

github

Committed by nduitz

Commit Message

Add put_polymorphic_embed/3

When the cast puts changesets into the changes of a polymorphic field,
the field has an Ecto embed type with one schema module. Ecto's
put_change/3, update_change/3 and change/2 then check each child against
that module, so they raise for children of another type. Ecto has no
place where polymorphic_embed can change that check.

put_polymorphic_embed/3 works as Ecto.Changeset.put_embed/4, but it finds
the matching data row by module and primary key, per element. So a list
can hold more than one type, and a single embed can change its type. It
accepts structs, changesets, maps and keyword lists. The type of a map
comes from its type field, from the data row with the same primary key,
or from the only type of the field. A new child gets its id at once, as
in the cast.

The changelog lists the new function, and the limit of Ecto's functions
as a breaking change.

The function keeps the changeset function that an earlier cast stored
for the forms, for example a with: function. An empty list replaces
data that holds only entries from the load options. The tests also
check that ordinary embeds in the data of a put child get their ids on
insert, and that the form keeps the id of a struct that the caller
gives.

As Ecto.Changeset.put_embed/4 does, the function gives the error "is
invalid" for a value that the field does not accept, for example nil for
a list of embeds, and keeps the data and the changes. A put inside a
prepare function of the parent prepares the embeds at once, as the cast
does.

Pull Request Pull Request #148: Ecto parity

Coverage Stats

261 of 296 new or added lines in 4 files covered. (88.18%)

9 existing lines in 1 file now uncovered.

520 of 606 relevant lines covered (85.81%)

520.2 hits per line