solidjs / solid / 40061804880

78%

main: 89%

push

github

fix(web): one value that fails to serialize no longer strands the pre-shell hydration stubs (#4242) (#4246)

Pending promises registered before the shell (async sources and Loading
boundaries' `<key>_fr` flags) were handed to seroval as one `$B` object
write. Since seroval 1.7 a value that fails to serialize ends the write it
belongs to, so one failure left every other stub in the batch pending on
the client, and hydration never finished. An async memo that resolves to
an element, such as a nested `<Loading>`, is enough.

The stubs are still held until the shell and handed over at the same
points and in the same order, but `flushStubBatch` writes each one as its
own key, the unit seroval isolates.

771 of 1066 branches covered (72.33%)

Branch coverage included in aggregate %.

1114 of 1358 relevant lines covered (82.03%)

27.71 hits per line