thumbor / libthumbor / 40056958969

100%

push

github

Warn about options CryptoURL.generate does not know

CryptoURL.generate accepted any keyword and silently dropped the ones it did
not read, so a typo such as widht=300 signed a URL without the resize, which
is also how thumbor-url lost its flip and crop flags. generate now emits a
DeprecationWarning naming the unknown options, with stacklevel=2 so it points
at the caller, and announces that they will raise in 3.0. The known set sits
next to get_url_parts as KNOWN_OPTIONS and covers every option it reads, the
aliases from the previous commits and unsafe. The thumbor-url test moves to
the CryptoURL tests, where it now also fails on any warning.

It is a warning rather than an error so callers passing extra keys keep
working through 2.x. DeprecationWarning is hidden by default outside __main__
and test runners, so typos will mostly surface in test suites. thumbor's
handler, url_composer, app, config and filter tests (485) pass against this
branch with the warning turned into an error, so thumbor itself passes
nothing unknown.

6 of 6 new or added lines in 2 files covered. (100.0%)

329 of 329 relevant lines covered (100.0%)

5.0 hits per line