psf / black / 40052318486

96%

master: 96%

push

github

Fix string_processing crash on strings in collections at small line lengths (#5521)

Don't wrap a collection string in parens when it still won't fit

StringParenWrapper wrapped list, tuple and set elements in parens even
when the new string line, one level deeper, was still over the line
length and StringSplitter couldn't split it there. At small line
lengths or deep nesting that only made the line longer. When an element
also carried a comment, StringSplitter then gave up on the wrapped
string after it had already taken it out of the tree, the next element
was split bare on the first pass and wrapped on the second, and the
stability check failed.

Skip the wrap in that case, as Black already does for strings without
spaces.

7008 of 7382 branches covered (94.93%)

8 of 8 new or added lines in 1 file covered. (100.0%)

10297 of 10729 relevant lines covered (95.97%)

5.73 hits per line