visgl / deck.gl / 40044906021

85%

push

github

fix(core): let GlobeController zoom past level 12 (#10737)

* fix(core): let GlobeController zoom past level 12

Above zoom 12 GlobeView renders with a WebMercatorViewport, which has no
getZoomAnchorStrength, so a pointer-anchored wheel zoom threw
'viewport.getZoomAnchorStrength is not a function' and the view could not
zoom in any further. Only ask a GlobeViewport for its anchor strength; a
WebMercatorViewport's map covers the screen, so anchor at full strength.

Fixes #10736

* test(core): cover the GlobeView zoom 12 viewport handoff

Adds the zoom-12 handoff case asked for in #10737 review: a wheel gesture
that starts at zoom 11.9 on a GlobeViewport and lands above 12 on a
WebMercatorViewport keeps the coordinate under the pointer.

* test(core): tighten GlobeController zoom anchor precision

The zoom 12 handoff case compared to 1 digit (0.05 degrees), which passed
even with pointer anchoring broken. Both cases now compare to 5 digits:
the measured residual is ~1e-6 degrees, a center-anchored zoom is ~5e-3.

---------

Co-authored-by: Chris Gervang <chris.gervang@joby.aero>
Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>

9854 of 12217 branches covered (80.66%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

16313 of 18879 relevant lines covered (86.41%)

28582.26 hits per line