IntelPython / dpnp / 40004195584

83%

push

github

Deprecate unused `dpnp.config` settings (#3107)

`dpnp.config` defines `__DPNP_QUEUE_GPU__`, `__DPNP_OUTPUT_NUMPY__` and
`__DPNP_OUTPUT_DPCTL_DEFAULT_SHARED__`, read from the `DPNP_QUEUE_GPU`,
`DPNP_OUTPUT_NUMPY` and `DPNP_OUTPUT_DPCTL_DEFAULT_SHARED` environment
variables, but nothing in dpnp uses them, so setting those variables has
no effect.

This PR deprecates the three attributes before removing them: they are
no longer module attributes but are served by a module-level
`__getattr__`, which returns the same value as before (still read from
the environment at import) and emits a `DeprecationWarning`:
```
`dpnp.config.__DPNP_OUTPUT_NUMPY__` is deprecated, and will be removed in a future release. It has no effect.
```
Any other unknown name still raises `AttributeError`. They can be
removed in a future release by deleting `_DEPRECATED_SETTINGS` and
`__getattr__`.

`__DPNP_ORIGIN__` and `__DPNP_RAISE_EXCEPION_ON_NUMPY_FALLBACK__` are
still used and are not changed. The test suite's own use of the
`DPNP_QUEUE_GPU` environment variable, which `dpnp/tests/conftest.py`
reads directly to pick the GPU skip list, is not affected.

The new `dpnp/tests/test_config.py` checks that each deprecated
attribute warns and returns its value, and that an unknown name raises
`AttributeError`. Importing `dpnp` emits no warning, and the warning
points at the caller's line.

1604 of 2994 branches covered (53.57%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 1 file covered. (100.0%)

29419 of 34552 relevant lines covered (85.14%)

17681.42 hits per line