bleedingdeacons / register / 40015036807

51%

Build Type

push

github

Committed by web-flow

Commit Message

feat: say what each Freedom change sets off, and keep one Unity site's records from another (#73)

A Freedom sync can change any key while the tablet runs. What that meant
was two prefixes in FreedomStartup (smtp., betterstack.) that no test
could reach. FreedomChangePlan now maps every key Register reads to its
effect: the mail queue, the log shipper, a Unity site check, or nothing
because it is read afresh each time. A test fails if a key in
FreedomSettings has no entry. A key the site holds and this build does
not read is logged as unused.

unity.base_url was the dangerous one. The Unity client factory reads it
afresh on every call, so a change mid-meeting meant Finish Meeting sent
the old site's registrations, member edits and consent to the new site,
where the same ids are other groups and members. UnitySiteGuard records
which site Load Unity fetched from. When Freedom points elsewhere, Finish
Meeting sends nothing, Load Unity refuses to bury unsent work, and the
operator is told as soon as the change arrives. Nothing is discarded:
point Freedom back and finish, or Reset Device.

Reset Device now deletes the compliance log as well as the registration
log, as OnDevice.feature says it does, and forgets the recorded site.

Coverage Stats

100 of 110 new or added lines in 5 files covered. (90.91%)

3 existing lines in 2 files now uncovered.

2243 of 4407 relevant lines covered (50.9%)

4.68 hits per line