kubernetes-sigs / external-dns / 40002035093
83%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 164
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.402% (-0.003%) from 82.405%
40002035093

push

github

web-flow 
fix(aws): validate geoproximity bias is within Route53 range [-99, 99] (#6762)

* fix(aws): validate geoproximity bias is within Route53 range [-99, 99]

The AWS provider parsed the geoproximity-location-bias annotation with strconv.ParseInt but never validated the range. Route53 only accepts a bias between -99 and 99 (per the GeoProximityLocation API), so an out-of-range value (e.g. "100") was accepted locally and then rejected by ChangeResourceRecordSets at reconcile time, landing the change in the failed-changes retry queue indefinitely.

This mirrors the existing validateCoordinates() pattern for latitude/longitude: on an out-of-range bias, log a warning and fall back to 0 (matching the existing parse-error fallback). Adds minBias/maxBias constants next to the lat/long bounds and out-of-range test cases to TestGeoProximityWithBias.

Signed-off-by: avneetbansal-aws <284363899+avneetbansal-aws@users.noreply.github.com>

* fix(aws): clamp out-of-range geoproximity bias to Route53 bounds

Per review feedback, clamp an out-of-range bias to the nearest valid bound (values below -99 -> -99, above 99 -> 99) instead of resetting to 0, so a value like 100 preserves the user's intent of a strong positive bias. Parse errors still fall back to 0. Updated the out-of-range test cases accordingly.

Signed-off-by: avneetbansal-aws <284363899+avneetbansal-aws@users.noreply.github.com>

* fix(aws): rewrite bias if-else chain to switch (gocritic)

Signed-off-by: avneetbansal-aws <284363899+avneetbansal-aws@users.noreply.github.com>

---------

Signed-off-by: avneetbansal-aws <284363899+avneetbansal-aws@users.noreply.github.com>
Co-authored-by: avneetbansal-aws <284363899+avneetbansal-aws@users.noreply.github.com>

16066 of 19497 relevant lines covered (82.4%)

1454.49 hits per line

Coverage Regressions

Lines Coverage ∆ File
50
87.89
0.05% aws/aws.go
1
86.92
-0.93% openshift_route.go
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest - 40002035093.1 164
82.4
GitHub Action Run
2 run-macos-latest - 40002035093.2 164
82.4
GitHub Action Run
Source Files on build 40002035093